v2 module incorrectly named #4271
Assignees
Labels
Comments
RaduBerinde
added a commit
to RaduBerinde/pebble
that referenced
this issue
Jan 21, 2025
A go module with version `v2.0` must have a path that ends in `/v2`; otherwise `go get` gives you a "module path must match major version" error. This commit enacts this change for the pebble-release-2.0. In the future we will consider making this change on master as well so we don't have inconsistency between the branches. Fixes cockroachdb#4271
|
Sorry for that, will fix right away. |
12 tasks
RaduBerinde
added a commit
to RaduBerinde/pebble
that referenced
this issue
Jan 22, 2025
A go module with version `v2.0` must have a path that ends in `/v2`; otherwise `go get` gives you a "module path must match major version" error. This commit enacts this change for the `pebble-release-2.0` branch. In the future we will consider making this change on master as well so we don't have inconsistency between the branches. Fixes cockroachdb#4271
RaduBerinde
added a commit
that referenced
this issue
Jan 22, 2025
A go module with version `v2.0` must have a path that ends in `/v2`; otherwise `go get` gives you a "module path must match major version" error. This commit enacts this change for the `pebble-release-2.0` branch. In the future we will consider making this change on master as well so we don't have inconsistency between the branches. Fixes #4271
|
I tagged a v2.0.1, it should work now. |
|
@RaduBerinde v2.0.1 is still using the wrong module path: /~https://github.com/cockroachdb/pebble/blob/v2.0.1/go.mod it doesn't work: $ go get github.com/cockroachdb/pebble/v2@v2.0.1
go: github.com/cockroachdb/pebble@v2.0.1: invalid version: module contains a go.mod file, so module path must match major version ("github.com/cockroachdb/pebble/v2") |
|
Oops, sorry, I tagged the wrong branch. Try now with v2.0.2 (I removed v2.0.1). |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Good afternoon,
I noticed your v2 branch doesn't have github.com/cockroachdb/pebble/v2 as it's module name.
Is this intentional?
I'm having some issues importing your v2 branch:
command
go get github.com/cockroachdb/pebble@v2.0.0output
go: github.com/cockroachdb/pebble@v2.0.0: invalid version: module contains a go.mod file, so module path must match major version ("github.com/cockroachdb/pebble/v2")I could be wrong but I think this is because your go.mod file shows github.com/cockroachdb/pebble as the module name instead of github.com/cockroachdb/pebble/v2
Jira issue: PEBBLE-326
The text was updated successfully, but these errors were encountered: