Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Clarify unit of cockpit.file's max_read_size option #17119

Merged
merged 1 commit into from
Mar 14, 2022
Merged

doc: Clarify unit of cockpit.file's max_read_size option #17119

merged 1 commit into from
Mar 14, 2022

Conversation

martinpitt
Copy link
Member

See #17118

@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Mar 11, 2022
@martinpitt
Copy link
Member Author

@elcarn23 do you think that this is better? I appreciate hints how to express the unit more clearly.

@martinpitt martinpitt temporarily deployed to cockpit-dist March 11, 2022 06:46 Inactive
@martinpitt martinpitt requested a review from marusak March 11, 2022 11:38
@elcarn23
Copy link

Yes, I think that's great. I appreciate the clarification on the parameter. Thanks again.

@marusak marusak merged commit 89f716c into cockpit-project:main Mar 14, 2022
@martinpitt martinpitt deleted the max-read-size-doc branch March 14, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marusak marusak marusak approved these changes

Assignees
No one assigned
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinpitt @elcarn23 @marusak