This repository has been archived by the owner on May 3, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Improve duffle.json docs #801
Merged
jeremyrickard
merged 1 commit into
cnabio:master
from
benpatt:751-duffle.json-references
Jul 24, 2019
Merged
Improve duffle.json docs #801
jeremyrickard
merged 1 commit into
cnabio:master
from
benpatt:751-duffle.json-references
Jul 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyn
suggested changes
Jul 22, 2019
docs/proposal/203-duffle-build.md
Outdated
|
||
`duffle build` take a path to a directory that contains a duffle build file (`duffle.json, duffle.toml, or duffle.yaml`) to build a Cloud Native Application Bundle (CNAB). In the process, it also builds all of the invocation images specified in the duffle build file. | ||
`duffle build` take a path to a directory that contains a duffle build configuration file (`duffle.json, duffle.toml, or duffle.yaml`) to build a Cloud Native Application Bundle (CNAB). In the process, it also builds all of the invocation images specified in the duffle build configuration file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benpatt Unrelated to this PR, but I wonder whether duffle.toml
or duffle.yaml
work? It would be worth investigating and raising a bug if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in this pull request: #803
glyn
reviewed
Jul 22, 2019
glyn
reviewed
Jul 22, 2019
glyn
approved these changes
Jul 23, 2019
Hey @benpatt thanks for the PR. Could you rebase this to resolve the conflicts in 203-duffle-build.md? |
benpatt
force-pushed
the
751-duffle.json-references
branch
from
July 24, 2019 07:49
222b83c
to
8854b86
Compare
Rebased. |
jeremyrickard
approved these changes
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #751