This repository has been archived by the owner on May 3, 2022. It is now read-only.
Add Docker Driver configuration options #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
This was referenced Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @radu-matei 's #651.
This adds support for additive container.Config / container.HostConfig options in the Docker Driver.
The motivation is that:
unix:///var/run/docker.sock, we want docker-app to detect that and customize the docker driver to actually bind mount the socket (which won't be done by default), and the invocation image with a user which has read/write access to it.This is a pretty important feature for docker-app local usage with Docker Dekstop
cc @chris-crone