This repository has been archived by the owner on May 3, 2022. It is now read-only.
feat: use Canonical JSON #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technosophos
force-pushed
the
feat/canonical-json-bundle
branch
from
e126f10 to
e25ecd7
Compare
radu-matei
reviewed
Jan 15, 2019
radu-matei
reviewed
Jan 15, 2019
radu-matei
approved these changes
Jan 15, 2019
|
I seriously spent over an hour fixing package import order issues because of the linter. If we have some stated order, can you point me toward it? Because it appears that the order the linter expects is: But it seems you are suggesting And my understanding was that imports within those sections were to be in alphabetical order, which would have |
|
Now that we moved passed the order import kerfuffle, this is tied to cnabio/cnab-spec#73. Is there anything preventing the spec PR from getting merged? It also needs a rebase. |
This switches Duffle to use Canonical JSON, which provides JSON ordering that is conducive to hashing. http://wiki.laptop.org/go/Canonical_JSON This will increase interoperability with other languages and platforms, and match the ordering produced by security tools like Notary. Note that this change does not impact: - Claims (still stored as regular JSON) - Drivers (still receive regular JSON) - Repo (still uses regular JSON)
technosophos
force-pushed
the
feat/canonical-json-bundle
branch
from
829f9ca to
cee0aa9
Compare
ghost
added
|
Rebased. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches Duffle to use Canonical JSON, which provides JSON ordering
that is conducive to hashing. http://wiki.laptop.org/go/Canonical_JSON
This will increase interoperability with other languages and platforms,
and match the ordering produced by security tools like Notary.
Note that this change does not impact: