-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User conemu cfg #1109
User conemu cfg #1109
Conversation
daxgames
commented
Oct 3, 2016
•
edited
Loading
edited
- Allows user to have a .config/user-conemu.xml file that is not %COMPUTERNAME% specific.
- Backs up the ./vendor/conemu-maximus5/conemu.xml file if it exist at startup to ./config/ConEmu-%COMPUTERNAME%.xml OR ./config/user-ConEmu.xml if one or the other already exists in that order. If neither exists the backup will default to ./config/user-ConEmu.xml this maintains a portable copy of changes made to this file while using cmder.
…ter specific and default ConEmu.xml files
3ee64b6
to
838e98f
Compare
838e98f
to
5feccb3
Compare
I do not like having to have a computer name in my custom config file that I want to be the same on all hosts. @kodybrown when I added the user-ConEmu.xml check after your computer specific check I removed some code, lines 129-132. I could not see that these lines actually did anything used by the cmder launcher. Will this break your situation somehow? |
4d0e929
to
9cf650f
Compare
You should be fine. Line 129 simply converts Envars to the real path. And, the other lines were to provide a way to get the 'normal' settings file if there wasn't a machine-specific version. Yeah, I think its fine. |
@kodybrown any comments on my add of backing up of the customized config file? I hated that my ongoing 'conemu.xml' customizations were lost of I deleted the vendor folder for a fresh install. This is nice since it backs up the continually changing 'conemu.xml' file to a computer named file (if it exists in ./config/) or user file if not at cmder launch. Only reason I ask is you are the only one who has expressed interest in custom config. |
Bump. Has anyone on the Cmder core team looked at this?
|
Sorry Dax, I'll look into it more tomorrow. |
No problem, was just wondering if there were questions. |
It looks fine after a first glance, will need to check the launcher code more thoroughly. |
Ok I did compile and test it with Visual Studio Community Edition 2015. It works in all situations but I am no c++ guru so that would be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@daxgames the checks here froze for whatever reason, can you push something to re-trigger them? |
@Stanzilla I've removed the one check that was preventing merges. |
@MartiUK alright, we also need a decision on which branch to use going forward, still dev and master for releases or all master. |
I can push it again as soon as my system comes back up. |
9cf650f
to
3b8d591
Compare
3b8d591
to
d64f0e6
Compare
Pushed, hopefully this allows checks to complete. |