This repository has been archived by the owner on Mar 16, 2022. It is now read-only.
Add TCK model test for CRDT entities #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll merge this now, so I can continue building on it for next steps. @marcellanz, just let me know if there are any issues from implementing this, and removing the state setting part of the CRDT protocol. |
|
@pvlugter thanks for the excellent work on this 👍 I'm down to a few failing test cases and found some bugs and implementation-specific differences too. Great to see the CRDT protocol verified by the TCK to this extent. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for CRDT entities to the TCK. Currently only implemented for Java support, with some small changes: tweaks to LWWRegister, and support for configuring write consistencies.
The TCK test class is getting quite long now. Will follow-up with some reorganisation to break this into multiple files.
And will follow-up with the rename of CRDT Entity to Replicated Entity once this is merged.