Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require AWS provider 5.16+ #123

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Require AWS provider 5.16+ #123

merged 4 commits into from
Nov 1, 2023

Conversation

raymondchen625
Copy link
Contributor

what

Version v0.36.0 does not work with AWS Provider 4.X.

why

In PR #121 of v0.36.0, the preference key scale_in_protected_instances, which had been available only since AWS Provider 5.16.0 introduced by PR#33310, was added. That basically upgrades the required AWS provider version to 5.16.0+.
We will get errors like the below while planning with AWS provider <5.16.0:

│ Error: Unsupported argument
│
│   on .terraform/modules/autoscale_group/main.tf line 187, in resource "aws_autoscaling_group" "default":
│  187:           scale_in_protected_instances = lookup(preferences.value, "scale_in_protected_instances", null)
│
│ An argument named "scale_in_protected_instances" is not expected here.

references

@raymondchen625 raymondchen625 requested review from a team as code owners October 23, 2023 17:56
@Gowiem
Copy link
Member

Gowiem commented Oct 25, 2023

/terratest

@Gowiem Gowiem added patch A minor, backward compatible change bugfix Change that restores intended behavior labels Oct 25, 2023
@Gowiem
Copy link
Member

Gowiem commented Oct 25, 2023

/terratest

@max-lobur max-lobur enabled auto-merge (squash) November 1, 2023 14:01
@max-lobur
Copy link
Contributor

/terratest

@max-lobur
Copy link
Contributor

/terratest

@max-lobur max-lobur merged commit ba1e6ce into cloudposse:main Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@max-lobur max-lobur max-lobur approved these changes

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raymondchen625 @Gowiem @max-lobur