Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #8065 #8264

Merged
merged 3 commits into from
Feb 26, 2025
Merged

fixes #8065 #8264

merged 3 commits into from
Feb 26, 2025

Conversation

dcartertwo
Copy link
Contributor

@dcartertwo dcartertwo commented Feb 26, 2025

Fixes #8065.

If in an existing git repository, don't ask the user if they would like to use git.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: minor change in default behavior

@dcartertwo dcartertwo requested review from a team as code owners February 26, 2025 03:21
Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: 2a07077

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 26, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13536233465/npm-package-wrangler-8264

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8264/npm-package-wrangler-8264

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13536233465/npm-package-wrangler-8264 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13536233465/npm-package-cloudflare-workers-bindings-extension-8264 -O ./cloudflare-workers-bindings-extension.0.0.0-v7feda93be.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v7feda93be.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13536233465/npm-package-create-cloudflare-8264 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13536233465/npm-package-cloudflare-kv-asset-handler-8264

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13536233465/npm-package-miniflare-8264

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13536233465/npm-package-cloudflare-pages-shared-8264

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13536233465/npm-package-cloudflare-unenv-preset-8264

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13536233465/npm-package-cloudflare-vite-plugin-8264

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13536233465/npm-package-cloudflare-vitest-pool-workers-8264

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13536233465/npm-package-cloudflare-workers-editor-shared-8264

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13536233465/npm-package-cloudflare-workers-shared-8264

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13536233465/npm-package-cloudflare-workflows-shared-8264

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.110.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.1
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will let someone else review but 👍

(think ci going to ask you for npx changeset)

@dcartertwo dcartertwo added the e2e Run wrangler e2e tests on a PR label Feb 26, 2025
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@petebacondarwin petebacondarwin merged commit 1f3af77 into main Feb 26, 2025
27 checks passed
@petebacondarwin petebacondarwin deleted the c3-better-existing-git-support branch February 26, 2025 07:04
@@ -0,0 +1,5 @@
---
"create-cloudflare": minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I debated with myself whether this is just a bug fix (i.e. patch) but I think we can go with it being a small feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c3-e2e e2e Run wrangler e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

npm create cloudflare — make prompt about initializing a git repo unnecessary
4 participants