Prepare to omit Content-Type header for files of unknown extension in Workers Assets #8247
Conversation
🦋 Changeset detectedLatest commit: be5587b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13513229739/npm-package-wrangler-8247You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8247/npm-package-wrangler-8247Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13513229739/npm-package-wrangler-8247 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13513229739/npm-package-cloudflare-workers-bindings-extension-8247 -O ./cloudflare-workers-bindings-extension.0.0.0-vade32ff5b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vade32ff5b.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13513229739/npm-package-create-cloudflare-8247 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13513229739/npm-package-cloudflare-kv-asset-handler-8247miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13513229739/npm-package-miniflare-8247@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13513229739/npm-package-cloudflare-pages-shared-8247@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13513229739/npm-package-cloudflare-unenv-preset-8247@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13513229739/npm-package-cloudflare-vite-plugin-8247@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13513229739/npm-package-cloudflare-vitest-pool-workers-8247@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13513229739/npm-package-cloudflare-workers-editor-shared-8247@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13513229739/npm-package-cloudflare-workers-shared-8247@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13513229739/npm-package-cloudflare-workflows-shared-8247Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
| @@ -0,0 +1 @@ | |||
| I'm a narcissist. | |||
| @@ -138,7 +138,7 @@ export const syncAssets = async ( | |||
| [(await readFile(absFilePath)).toString("base64")], | |||
| manifestEntry[1].hash, | |||
| { | |||
| type: getContentType(absFilePath), | |||
| type: getContentType(absFilePath) || "application/octet-stream", | |||
There was a problem hiding this comment.
For future readers, this is the line that allows us to gradually roll this feature out before production support is in place.
Fixes WC-3028.
This isn't quite everything. This makes it work in
wrangler devand prepares the asset-worker in production to be able to handle missing contentType metadata. We'll need to land this, then API support, and then follow up with the final piece here.