"Table" union type definition fix #53
Conversation
|
Thanks @macieklad - Can you expand a little more on the problem you encountered? Thanks! |
|
Actually @macieklad - Could you open an issue describing the problem? I will then mark that as Hacktoberfest ;) Thanks for your contribution. |
|
Yes, I already did it with the pull request in #54 :) |
|
Thanks for the fix @macieklad - I am still very new to TypeScript, and while the code and your reasoning makes complete sense, I wonder whether @Turbo87 or @DanielRuf might want to have a look at this? |
| interface VerticalTableRow { | ||
| [name: string]: Cell; | ||
| } | ||
|
|
||
| type CrossTable = GenericTable<CrossTableRow>; |
There was a problem hiding this comment.
removing these types should be considered a breaking change IMHO. can you please add them back?
There was a problem hiding this comment.
@DanielRuf Thoughts? I am in no position to comment.
There was a problem hiding this comment.
removing these types should be considered a breaking change IMHO. can you please add them back?
I agree here. Can we keep this type somehow?
|
please release this fix. |
Suggested fix for the "Table" union type definition error