Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Privacy] moves account section from core plugin #2489

Merged
merged 10 commits into from
May 19, 2023
Merged

[Privacy] moves account section from core plugin #2489

merged 10 commits into from
May 19, 2023

Conversation

Noelle-M
Copy link
Contributor

@Noelle-M Noelle-M commented May 18, 2023 •
edited by Elorfin
Loading

Q A
Bug fix? no
New feature? no
BC breaks? no

@Noelle-M
Copy link
Contributor Author

J'avais supprimer le dossier privacy dans src/main/core/Resources/modules/account/privacy puisque plus raison d'être mais cela pose problème lors de la PR

@Elorfin
Copy link
Member

Elorfin commented May 19, 2023

Ne peut être mergé, il y a le contenu de : #2490.
Quand tu fais plusieurs PRs en parallèle tu dois forcément repartir de la branche cible (ici main).

Tu ne peux donc pas faire plusieurs PRs en même temps sur la même section du code.

@Elorfin Elorfin changed the title moving privacy account core=> main->privacy [Privacy] moves account section from core plugin May 19, 2023
@Elorfin Elorfin merged commit 3fd36bc into main May 19, 2023
@Elorfin Elorfin deleted the account-privacy branch May 19, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elorfin Elorfin Elorfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noelle-M @Elorfin