Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ConnectionMessage] adds message for missing emails config #2474

Merged
merged 7 commits into from
May 10, 2023
Merged

[ConnectionMessage] adds message for missing emails config #2474

merged 7 commits into from
May 10, 2023

Conversation

WolfyWin
Copy link
Contributor

@WolfyWin WolfyWin commented May 9, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Fixed issues comma-separated list of issues fixed by the PR, if any

  • Add 3 sub-methods to displayVersionChangeLogs :

    • getChangelogs
    • getDPOMessages
    • getSupportMessages

  • Check role and display message only if Admin role and email is not set.

  • Translations added in platform.fr/en.json.

  • Adding a link to the change to be made in the message.

  • Typing RoutingHelper.

@WolfyWin WolfyWin changed the base branch from 13.8 to main May 9, 2023 13:28
@WolfyWin WolfyWin requested a review from Elorfin May 9, 2023 14:14
Elorfin
Elorfin reviewed May 10, 2023
View reviewed changes
Copy link
Member

@Elorfin Elorfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rajouter 2 utilitaires adminPath et adminUrl dans RoutingHelper.
  • Rajouter le typing pour les params des méthodes dans RoutingHelper.

@Elorfin Elorfin changed the title Messages modal [ConnectionMessage] adds message for missing emails config May 10, 2023
@Elorfin Elorfin merged commit db43835 into main May 10, 2023
@Elorfin Elorfin deleted the messagesModal branch May 10, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elorfin Elorfin Elorfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WolfyWin @Elorfin