Explicit Ajax helpers for new response types #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1ames
suggested changes
Dec 16, 2020
f1ames
approved these changes
Dec 22, 2020
There was a problem hiding this comment.
LGTM 👍
One note regarding docs and custom @params - now you will see that building docs show a warning about "unknown type":
It doesn't change the resulting docs itself (it is still shown correctly AFAIS), however it's there to say something is missing and should be fixed most probably. For such occasions we have external types definition in docs JSDuck task. I have already covered that on major branch.
|
Rebased onto latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
New feature - according to #4394
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
Give an overview…
Added two methods:
based on the current
loadmethod.Rename ajax load methods in tests. For those called
loadwithrsponseTypeset to 'text' or 'arraybuffer' - I replace them with newly createdloadTextandloadBinary. Since it's a new API with predefinedresponseType- tests can be based on the newest changes. Also, add issue markers for tests based onloadTextandloadBinary.Which issues does your PR resolve?
Closes #4394