Added mentions items limit option #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekbogdanski
force-pushed
the
t/1703-b
branch
2 times, most recently
from
b457315 to
305bde6
Compare
mlewand
approved these changes
Jun 19, 2018
There was a problem hiding this comment.
Works well, there's a small difference that you have not reflected itemsLimit property in Mentions type, as most of other config properties are.
Looking at it I see that it should be simplified in the main Mentions ticket simply by assigning provided mentions.configDefinition object as a config property of Mentions instance. That way we'll remove many stray lines. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
New feature
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Tests are available for
autocompleteplugin.What changes did you make?
Added mentions items limit option.
Closes #2100