CKEditor 4 - Selecting whole content by pressing Control + A & press Delete on Keyboard doesn’t erase all bullet points On first try

[sridharravva]

Hi,
I have tried this using CKEditor 4 - Standard Package Version 4.16.1 and Standard Package Version 4.16.2 and found this bug on Chrome browser. Basically, under Chrome browser, when I am selecting whole content in CKEditor by pressing Control + A & press Delete on Keyboard then it doesn’t erase all bullet points On first try. We could delete whole content present on CKEditor in multiple attempts and not in one single attempt. It looks like there is some bug with this CKEditor control only in Chrome browser since it works fine on Firefox browser, no issue with that FF browser.
Can someone please advice how to resolve this issue on Chrome browser? Thanks!

Here it is sample content that I tried erasing it on CKEditor 4 control by pressing Control + A and then Press Delete button on Keyboard

[KarolDawidziuk]

Hi, @sridharravva
Thank you for the report.
For me, everything looks okay. I created a similar content as you provide but it works (tested on both versions).

Could you give more information? like:
OS:
Installed CKEditor plugins:
Chrome version:

[sridharravva]

Hi, @sridharravva Thank you for the report. For me, everything looks okay. I created a similar content as you provide but it works (tested on both versions).

Could you give more information? like: OS: Installed CKEditor plugins: Chrome version:

I have tried with the CKEditor 4.16.1 Standard package with above bulleted content on Windows 10 machine and Chrome browser.
Basically, under Chrome browser, when try selecting whole content in CKEditor by pressing Control + A & then press Delete on Keyboard then you can see, it won't let you erase all bullet points On single first try. We could only delete whole content present on CKEditor in multiple attempts and not in one single attempt.
I see the same issue with Edge browser as well.
Installed plugins are font, wordcount, pastetools and clipboard and few other plugins that came as part of standard package of CKEditor 4.16.1.
Please let me know how to resolve this issue erasing all bulleted content in CKEditor in single try and not in multiple tries.
Here it is the complete list of plugins that I have it for CKEditor 4.16.1:

[KarolDawidziuk]

Hi, @sridharravva
Thank you for more details.

I can confirm this issue.
In conclusion. This problem occurred on

• OS: Win10(tested on VBox)
• Browsers: Chrome/Edge/IE
• Firefox and browsers on macOS work properly

Screen.Recording.2021-10-16.mov

[sculpt0r]

Probably fixed in #4943 - to verify

[KarolDawidziuk]

Unfortunately, #4943 didn't fix it.
It's looking like a selection problem on Windows.

[sculpt0r]

For now - it looks like a selection problem (not a problem with deleting list items) - only when the last element in list is empty. Reproducible even with small source sample:

<ol>
	<li>1</li>
	<li>&nbsp;</li>
</ol>

If you put anything instead of nbsp - the selection looks fine. But with the nbsp - it 'skips' the last element 🤔

The selection is fine if I use the "Select all" plugin - so the entire list is deleted.

If I remove widgetselection (and all plugins that requires it) - the issue is also reproducible on macOS:

	removePlugins: 'uploadimage, uploadwidget, widget, widgetselection'

With Cmd/Ctrl + A and removed plugins: the selection behaves the same on both OS.

On macOS - events logs in widgetselection:

but on Win10 - there is one event missed:

[sculpt0r]

Also, we have a comment:

ckeditor4/plugins/widgetselection/plugin.js

Lines 7 to 10 in 3238b84

	* @fileOverview A plugin created to handle ticket https://dev.ckeditor.com/ticket/11064. While the issue is caused by native WebKit/Blink behaviour,
	* this plugin can be easily detached or modified when the issue is fixed in the browsers without changing the core.
	* When Ctrl/Cmd + A is pressed to select all content it does not work due to a bug in
	* Webkit/Blink if a non-editable element is at the beginning or the end of the content.

And then, this method behaves differently on Win10:

ckeditor4/plugins/widgetselection/plugin.js

Line 212 in 3238b84

isWholeContentSelected: function( editable ) {

in the return statement:

ckeditor4/plugins/widgetselection/plugin.js

Line 225 in 3238b84

rangeClone.startOffset === 0 && rangeClone.endOffset === editable.getChildCount() &&

on Win10 - the rangeClone.endOffset is equal to 0 whereas on macOS - it is 1 - so the entire method returns different boolean and fixes are not applied on Win10

The editor behaves differently on debugger than in casual...

[sculpt0r]

I switched to testing this behavior with logs - since debugging step-by-step produce unpredictable results 🤔

Method mentioned before

ckeditor4/plugins/widgetselection/plugin.js

Line 212 in 3238b84

isWholeContentSelected: function( editable ) {

returns false on macOS and true on Win10. Because of that - additional filters are not applied (on Win10) after the if statement:

ckeditor4/plugins/widgetselection/plugin.js

Line 125 in 3238b84

if ( !this.isWholeContentSelected( editable ) && editable.getChildCount() > 0 ) {

on macOS the functions early return false, because the range is collapsed:

ckeditor4/plugins/widgetselection/plugin.js

Lines 217 to 218 in 3238b84

	if ( range && range.collapsed ) {
	return false;

but on Win10 the range is not collapsed - so the functions go to the big return statement which evaluates to true:

ckeditor4/plugins/widgetselection/plugin.js

Lines 224 to 226 in 3238b84

	return !!( rangeClone && editable && rangeClone.startContainer && rangeClone.endContainer &&
	rangeClone.startOffset === 0 && rangeClone.endOffset === editable.getChildCount() &&
	rangeClone.startContainer.equals( editable ) && rangeClone.endContainer.equals( editable ) );

According to spec the collapsed value is based on the selection anchor and focus properties. Based on my logs, we have different values in the native selection object (between the OS):
on macOS: anchorNode and focusNode are the same (both are the text):

but on Win10 - they are not:

The text from macOS selection are the additional filter applied by widgetselection plugin:

[sculpt0r]

All unit tests are passing on Chrome Win10 under tags:

• widgetselection
• selection
• range
• selectAll

[CKEditorBot]

Closed in #5291