Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image in table cell has an empty URL field when edited from context menu opened by right-click #2235

Closed
a-hecht opened this issue Jul 17, 2018 · 5 comments · Fixed by #3059
Closed
Assignees
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:image The plugin which probably causes the issue. plugin:tableselection The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@a-hecht
Copy link

a-hecht commented Jul 17, 2018

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Create a new table in ckeditor.
  2. Put a single image in one of the cells.
  3. Right click the image to open context menu.
  4. Choose "Image Properties" from context menu to open the "Image Properties" dialog.

Expected result

The fields of the "Image Properties" dialog should be populated with the corresponding properties of the image that was right-clicked.

Actual result

The fields of the "Image Properties" dialog remain empty.

Other details

Browsers: Current versions of Chrome/Chromium and Firefox under Linux and Windows 7/10.
CKEditor versions tested: 4.10.0 and 4.9.2
The issue only occurs if "Image Properties" was called via context menu and the image is the sole content of a table cell. Double clicking the image or selecting it and calling the dialog via tool bar operates as expected.
A possible cause of this bug maybe located in the selection range handling of the function isTableSelection (in core/selection.js)

@engineering-this
Copy link
Contributor

Confirmed with image plugin. Not reproducible with image2.

@engineering-this engineering-this added status:confirmed An issue confirmed by the development team. type:bug A bug. plugin:image The plugin which probably causes the issue. labels Jul 23, 2018
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:minor Any docs related issue that can be merged into a master or major branch. labels Jul 23, 2018
@dwahlqvist
Copy link

Unfortunately image2 lacks functionality we need e.g. link tab, i.e. changing to it is not a valid work around for us.
Looking forward to a bug fix :)

@iwrconsultancy
Copy link

I reported this a long while back. It seems to date back at least as far as CK4.7.
Demonstration page at http://iwrconsultancy.co.uk/ckbug
The issue seems to be in ckeditor.js itself rather than any plugin.

@Dumluregn Dumluregn self-assigned this Mar 15, 2019
@f1ames f1ames added the plugin:tableselection The plugin which probably causes the issue. label Apr 3, 2019
@f1ames
Copy link
Contributor

f1ames commented Apr 3, 2019

This issue is caused by tableselection plugin which was introduced in 4.7.0. While using right mouse button to open context menu (by clicking on image) the whole table cell gets selected instead of an image and the properties are not correctly propagated to the dialog (because selection points to table cell not an image).

Bug was introduced in 4.7.0 and is still reproducible in 4.11.3.

@lslowikowska lslowikowska added the support:3 An issue reported by a commercially licensed client. label Apr 4, 2019
@f1ames f1ames added this to the 4.11.5 milestone Apr 4, 2019
@f1ames
Copy link
Contributor

f1ames commented Apr 4, 2019

Since the issue is caused by tableselection plugin, disabling it resolves the issue which may work as a workaround.

Another workaround is to use keyboard (instead of mouse) to open context menu while the image is selected. The context menu keyboard shortcut is Shift + F10. Also Image Properties dialog can be opened via double-clicking on the image instead of opening it via context menu which also works correctly in the above scenario.

@lslowikowska lslowikowska added support:2 An issue reported by a commercially licensed client. and removed support:3 An issue reported by a commercially licensed client. labels Apr 4, 2019
@Dumluregn Dumluregn changed the title Image in table cell is not editable via context menu Image in table cell has an empty URL field when edited from context menu opened by right-click Apr 16, 2019
f1ames added a commit that referenced this issue May 9, 2019
@f1ames f1ames added the regression This issue is a regression. label May 9, 2019
@f1ames f1ames modified the milestones: 4.11.5, 4.12.0 May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:image The plugin which probably causes the issue. plugin:tableselection The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
8 participants