-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI related improvements #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please quote all variables.
And lets use CI_BUILD to set OUT.
OUT="$PWD/../build-$VER"
if [ "$CI_BUILD" = "true" ]; then
OUT=$WHERE_YOU_WANT_IT_FOR_CI"
fi
Last, check CI_BUILD lie BOOTTEST is checked. accepted values are empty, false or true.
CI_BUILD="${CI_BUILD:-false}"
case "$CI_BUILD" in
true|false) echo "bad value '$CI_BUILD' for CI_BUILD"; exit 1;;
esac
Just to note, this might also just be specific to me, but I did not have any issues with using That being said, I think this pull request should also update |
#83 does that |
By default those two directories are created in parent directory. Which makes telling Github Actions which dirs to cache harder. Change-Id: I582d24d5993ca4739cebd3c38f45a5df76cded47
fetching sources copied some files into wrong place
On CI we may want to tell where exactly build dir we want to be. GitHub Actions for example dislike paths with ".." in them. CI_BUILD_OUT gets $PWD added in build-release script. (taken from patch done by Dr. Jens Harbott) Change-Id: I73ce170f12ca035893b810c2314bd0aa429c4f5b
build works, artifacts upload works, cache is reused |
When we do builds on CI we may want to be able to define where build directory is (instead of ../build-*".
Another thing is location of download/ and ccache/ directories - GitHub Actions dislike paths with ".." in them. Moving those to checked out sources (where it was linked before) allows to make caches easier.