Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Scala 3 and Monocle 3 #348

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Upgrade to Scala 3 and Monocle 3 #348

merged 1 commit into from
Sep 20, 2023

Conversation

joan38
Copy link
Contributor

@joan38 joan38 commented Sep 19, 2023

All credits to @inanme

cc @GreyPlane

@joan38
Copy link
Contributor Author

joan38 commented Sep 19, 2023 •
edited
Loading

@GreyPlane 1 more approval needed for the CI

@GreyPlane GreyPlane mentioned this pull request Sep 20, 2023
Closed
GreyPlane
GreyPlane approved these changes Sep 20, 2023
View reviewed changes
README.md Outdated
and circe-optics version numbers are a coincidence and NOT intentional.
Please use the following table for determining capability with the corresponding [Circe] versions.

| Circe Optics Version | Circe | Monocle | Scala 2 | Scala 3 | Scala JVM | Scala.JS | Scala Native |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should remove 'Scala Native'

build.sbt Outdated
val scala213 = "2.13.12"
val scala3 = "3.2.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess Scala 3.3.0 would be better?

@joan38
Copy link
Contributor Author

joan38 commented Sep 20, 2023 •
edited
Loading

@GreyPlane Addressed the comments.

1 workflow awaiting approval
This workflow requires approval from a maintainer

I need approval to run CI:

@joan38 joan38 force-pushed the scala3 branch 2 times, most recently from b7767b3 to cb08da0 Compare September 20, 2023 03:49
@GreyPlane
Copy link
Contributor

GreyPlane commented Sep 20, 2023 •
edited
Loading

@GreyPlane Addressed the comments.

1 workflow awaiting approval

This workflow requires approval from a maintainer

I need approval to run CI:

I'm afraid that has to be done by a maintainer and I'm not :(

@joan38
Copy link
Contributor Author

joan38 commented Sep 20, 2023

Who are the maintainers of this repo? @travisbrown ?

@joan38
Copy link
Contributor Author

joan38 commented Sep 20, 2023

@zarthross ? Are we good to merge?

@aheiska
Copy link

aheiska commented Sep 20, 2023 •
edited
Loading

Should versioning-table have own columns for 2.12 and 2.13 instead of Scala 2.

@joan38
Copy link
Contributor Author

joan38 commented Sep 20, 2023

@aheiska The table is mostly to highlight the Monocle and Circe version it relates to. I let Scala 2 and Scala 3 to do like circe-extra

@joan38
Copy link
Contributor Author

joan38 commented Sep 20, 2023 •
edited
Loading

Ping @zarthross.
Sorry for the insisting push on this, but we are contemplating forking this repo @Netflix to get everyone moving forward.

zarthross
zarthross approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@zarthross zarthross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, this looks good to me. I think we can get a release cut shortly.

zarthross
zarthross reviewed Sep 20, 2023
View reviewed changes
README.md Show resolved Hide resolved
@zarthross
Copy link
Member

Closes #336
Closes #231
Closes #243

@zarthross zarthross merged commit 896a1e4 into circe:master Sep 20, 2023
@joan38 joan38 deleted the scala3 branch September 20, 2023 22:36
@joan38
Copy link
Contributor Author

joan38 commented Sep 20, 2023 •
edited
Loading

👏🏼 Thanks @zarthross @inanme @arixmkii @hughsimpson @GreyPlane @zmccoy @zmccoy for the help

@zarthross
Copy link
Member

/~https://github.com/circe/circe-optics/releases/tag/v0.15.0

@zarthross
Copy link
Member

This should be landing on maven soon, its past CI out in sonatype land now. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarthross zarthross zarthross approved these changes

@GreyPlane GreyPlane GreyPlane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joan38 @GreyPlane @aheiska @zarthross