Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data races by avoiding global CLI logger #43

Merged
merged 18 commits into from
Apr 22, 2021
Merged

Conversation

aaronsky
Copy link
Member

@aaronsky aaronsky commented Apr 20, 2021

Refactor logging implementation to avoid problematic use of global logger.

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2021

Codecov Report

Merging #43 (87642a6) into main (8b746fa) will decrease coverage by 0.92%.
The diff coverage is 64.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   81.79%   80.87%   -0.93%     
==========================================
  Files          36       38       +2     
  Lines        2324     2337      +13     
==========================================
- Hits         1901     1890      -11     
- Misses        326      345      +19     
- Partials       97      102       +5     
Impacted Files Coverage Δ
internal/clicommand/completions.go 94.73% <ø> (ø)
internal/clicommand/release.go 68.25% <0.00%> (-0.73%) ⬇️
internal/client/assets.go 44.07% <0.00%> (-0.32%) ⬇️
internal/client/client.go 86.84% <ø> (ø)
internal/git/git.go 100.00% <ø> (ø)
internal/log/log.go 0.00% <0.00%> (ø)
internal/parallel/group.go 100.00% <ø> (ø)
internal/pipe/git/git.go 97.56% <ø> (-2.44%) ⬇️
internal/template/template.go 100.00% <ø> (ø)
internal/shell/shell.go 84.09% <53.33%> (-15.91%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09b23b...87642a6. Read the comment docs.

@aaronsky aaronsky changed the title Testing CI data race troubles Experimenting with data race detection Apr 20, 2021
@aaronsky aaronsky marked this pull request as ready for review April 22, 2021 03:52
@aaronsky aaronsky changed the title Experimenting with data race detection Remove data races by avoiding global CLI logger Apr 22, 2021
@aaronsky aaronsky merged commit 4363ab8 into main Apr 22, 2021
@aaronsky aaronsky deleted the data_race_testing branch April 22, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants