Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

status can't print diff when different path than root #18

Closed
davesnx opened this issue Apr 11, 2023 · 4 comments
Closed

status can't print diff when different path than root #18

davesnx opened this issue Apr 11, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@davesnx
Copy link

davesnx commented Apr 11, 2023 •
edited
Loading

Hi @chshersh, really good tool. Thanks for the effort and style on zbg.

I'm using it and found a bug when running status from a different path than root (containing the .git folder)

→ $ zbg status
 modified  .gitignore                         |   1 ■
 modified  dune                               |   2 ■■
 modified  dune-project                       |   2 ■■
 modified  e2e/rescript-v9-JSX3/bsconfig.json |   3 ■■■
 modified  e2e/rescript-v9-JSX3/package.json  |   3 ■■■
 modified  e2e/rescript-v9-JSX3/yarn.lock     | Bin 87888 -> 64994 bytes
 added     packages/css/bsconfig.json         |   8 ■■■■■■■■

→ $ cd bin

→ $ zbg status
 modified  .gitignore                         | 0 <unable to match file>
 modified  dune                               | 0 <unable to match file>
 modified  dune-project                       | 0 <unable to match file>
 modified  e2e/rescript-v9-JSX3/bsconfig.json | 0 <unable to match file>
 modified  e2e/rescript-v9-JSX3/package.json  | 0 <unable to match file>
 modified  e2e/rescript-v9-JSX3/yarn.lock     | 0 <unable to match file>
@chshersh chshersh added the bug Something isn't working label Apr 11, 2023
@chshersh
Copy link
Owner

Hi @davesnx 👋🏻

Thanks for the bug report!

This is an expected problem, I have to look into the fix 👀
Indeed, would be nice to fix it!

tekknoid added a commit to tekknoid/zbg that referenced this issue Jun 10, 2023
@tekknoid
Resolving issue chshersh#18 - status can't print diff when different …
969f00d 
…path than root
@tekknoid tekknoid mentioned this issue Jun 10, 2023
Merged
chshersh pushed a commit that referenced this issue Jun 26, 2023
@tekknoid
Resolving issue #13, #18 and #25 (#24)
4d64874 
* Resolving issue #18 -  status can't print diff when different path than root
* fixed switch but - it will switch to default branch instead of "main"
* Added force alias to -f
* Code formatting
@chshersh
Copy link
Owner

Fixed by:

@chshersh chshersh reopened this Jun 26, 2023
@chshersh
Copy link
Owner

@davesnx This problem was kindly fixed by @tekknoid 💝

I would appreciate it if you could have a chance to test the change by building from the latest main. Thanks! 🙏🏻

@davesnx
Copy link
Author

davesnx commented Sep 15, 2023

It's solved, Thanks!

@davesnx davesnx closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davesnx @chshersh