[#57] Adds install command to install known tools #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Im not sure what tests can be added to make sure everything works properly. |
chshersh
requested changes
Sep 15, 2022
src/lib.rs
Outdated
Comment on lines
39
to
48
| Command::Install { name } => { | ||
| if let Some(tool_info) = lookup_tool(&name) { | ||
| if let Ok(mut tool) = toml::parse_file(&config_path) { | ||
| let tool_btree: BTreeMap<String, ConfigAsset> = | ||
| BTreeMap::from([(name, tool_info.into())]); | ||
| tool.tools = tool_btree; | ||
| sync(tool); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Ideas for future improvements (can be done as separate issues):
- Update the config to add a new tool (so it later will be updated with
sync) - Support all
ConfigAssetfields as arguments to theinstallcommandj - Allow downloading the tool from the parsed config if it's already specified in there
I think we can add similar integration tests in the |
MitchellBerend
commented
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #57
This pr adds an
isntallsubcommand that lets the user install any of the hardcoded tools. As a bonus it also implements theFromtrait to convert fromToolInfoToConfigAsset.Additional tasks