Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#49] Specify which version of the tool was actually downloaded #60

Merged
merged 2 commits into from
Sep 3, 2022

Conversation

MitchellBerend
Copy link
Collaborator

This resolves #49

I took a stab at implementing this but Im not sure if my approach is the right
way to go. Because the list of tools is already known before actually calling
the github api the length of these names is also known. This is not that case
with the tag_name. The tags from the example file are all less than 7 long but
that does not guarantee other repos.

I could try and check what tags are available for all tools before actually
downloading them. Can I get your input on this?

$ cargo run -- --config tools.toml sync
    Finished dev [unoptimized + debuginfo] target(s) in 0.02s
     Running `target/debug/tool --config tools.toml sync`
✅  bat        v0.21.0  Completed!
✅  difftastic 0.34.0   Completed!
✅  exa        v0.10.1  Completed!
✅  fd         v8.4.0   Completed!
✅  ripgrep    13.0.0   Completed!

@chshersh chshersh added the enhancement New feature or request label Sep 2, 2022
@chshersh
Copy link
Owner

chshersh commented Sep 2, 2022

@MitchellBerend Wow, thanks a lot for working on this! I'll have a look as soon as I can 🤗

@MitchellBerend
Copy link
Collaborator Author

#61 might actually solve the issue that I have with my pr since it does actually give some idea about the length of the tag before the program reaches out to github. We can maybe assume latest as the lower bound and the longest tag as the upper bound like you did with max_tool_size

Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MitchellBerend Thanks a lot for the implementation!

I think this change is good on its own so I'm happy to merge it 👏🏻
Further improvements can be done after #32 is fixed (for example, it would be nice to see the version during the Downloading phase as well). But I propose to do this after #61 merged 🚢

@chshersh chshersh merged commit 5fe6d5d into chshersh:main Sep 3, 2022
@chshersh chshersh changed the title Resolves #49 [#49] Specify which version of the tool was actually downloaded Sep 3, 2022
@MitchellBerend MitchellBerend deleted the 49-tag_name-on-download branch September 3, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify which version of the tool was actually downloaded
2 participants