Refactor custom 'display()' functions to use the 'Display' trait

[chshersh]

See the discussion in #83

The idea is to implement the std::fmt::Display trait for data types where we already use a custom display() function. Specifically:

• TomlError::display

  • tool-sync/src/config/toml.rs

    Lines 16 to 24 in b79eeb9

    	impl TomlError {
    	pub fn display(&self) -> String {
    	match self {
    	TomlError::IO(e) => format!("[IO Error] {}", e),
    	TomlError::Parse(e) => format!("[Parsing Error] {}", e),
    	TomlError::Decode => "[Decode Error]".to_string(),
    	}
    	}
    	}

• ToolError::display

  • tool-sync/src/model/tool.rs

    Lines 20 to 29 in b79eeb9

    	impl ToolError {
    	pub fn display(&self) -> String {
    	match self {
    	ToolError::Suggestion { perhaps } => {
    	format!("[suggestion] Perhaps you meant: '{}'?", perhaps)
    	}
    	ToolError::Invalid => "[error] Not detailed enough configuration".to_string(),
    	}
    	}
    	}

• UnpackError::display

  • tool-sync/src/sync/archive.rs

    Lines 27 to 37 in b79eeb9

    	impl UnpackError {
    	pub fn display(&self) -> String {
    	match self {
    	UnpackError::IOError(e) => format!("{}", e),
    	UnpackError::ZipError(e) => format!("{}", e),
    	UnpackError::ExeNotFound(archive_name) => {
    	format!("Can't find executable in archive: {}", archive_name)
    	}
    	}
    	}
    	}

Implementation example:

enum TestEnum {
    Var1(String),
    Var2(String),
}


impl fmt::Display for TestEnum {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            TestEnum::Var1(s) => write!(f, "[VAR1]: {}", s),
            TestEnum::Var2(s) => write!(f, "[VAR2]: {}", s),
        }
    }
}

[zixuan-x]

Sicne I just worked with implementing Display trait, this issue is probably a good one for me to get more familiar with the code base. If it's not taken then I'll start working on it?

[chshersh]

@zixuanzhang-x Sounds like an excellent next issue 🥇

It's not taken. And I think @MitchellBerend will be really pleased when this one is done so we can unlock:

• Refatoring of all functions that print to stdout/err so they accept a generic type that implements the Display trait #98