Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #32 - Allow icons in table mode to work #33

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

eblis
Copy link

@eblis eblis commented Nov 5, 2022

Allow configured icons to work in table mode.

Copy link
Owner

@chrisant996 chrisant996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inefficient. Using the Lua table index syntax is more efficient.

I would prefer to see a change in README.md that adds an example of how to use table mode for .use_icons properly.

@eblis
Copy link
Author

eblis commented Nov 5, 2022

Ah, I just saw this comment. I did follow the readme, I'll update and fix it then.
I tried setting table = { "VPN" = true } but that didn't work so I assumed it's not possible. I didn't know I shouldn't use quotes.

eblis added 2 commits November 5, 2022 20:52
…mat; now also explains how to forcefully disable certain icons (setting to false)
@chrisant996
Copy link
Owner

Ah, I just saw this comment. I did follow the readme, I'll update and fix it then.
I tried setting table = { "VPN" = true } but that didn't work so I assumed it's not possible. I didn't know I shouldn't use quotes.

You should use brackets and quotes. No brackets and no quotes is a shortcut, but doesn't work if the string contains non-letters for example.

Read up on Lua tables for more info.

@eblis
Copy link
Author

eblis commented Nov 5, 2022

I changed the pull request to explain how to use the table format in the readme

Copy link
Owner

@chrisant996 chrisant996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

@chrisant996 chrisant996 merged commit aa154df into chrisant996:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants