Avoid double logging removal of non-mach-o libs #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
force-pushed
the
improve_mac_logging
branch
from
060a31a to
7aea7a4
Compare
lamont-granquist
approved these changes
Nov 10, 2021
is_macho? would call is_binary?, which resulted in double logging. Just duplicate the 1 line of logic and avoid double logging in the builds. This will nuke hundreds of lines of log output on macs. I also changed up these methods to returns instead of carrying around a boolean. It feels more "ruby-like" now. Maybe that's just my personal preference for flow control though. Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
improve_mac_logging
branch
from
2682059 to
d8aef34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_macho? would call is_binary?, which resulted in double logging. Just
duplicate the 1 line of logic and avoid double logging in the builds.
This will nuke hundreds of lines of log output on macs. I also changed
up these methods to returns instead of carrying around a boolean. It
feels more "ruby-like" now. Maybe that's just my personal preference for
flow control though.
Signed-off-by: Tim Smith tsmith@chef.io