Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for light to delay validation #842

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

jmartin-tech
Copy link
Contributor

Description

Add support for delayed validation in WiX light.exe tool, see -sval option.

Build the MSI that will be run against Smoke. Pass the -sval argument to delay validation until Smoke is run.

usage:

package :msi do
  wix_light_delay_validation true
end

Maintainers

Please ensure that you check for:

  • If this change impacts git cache validity, it bumps the git cache
    serial number
  • If this change impacts compatibility with omnibus-software, the
    corresponding change is reviewed and there is a release plan
  • If this change impacts compatibility with the omnibus cookbook, the
    corresponding change is reviewed and there is a release plan

@jmartin-tech jmartin-tech requested a review from a team as a code owner July 12, 2018 16:18
@marcparadise
Copy link
Member

@jmartin-r7 if you can also rebase this one after #843 merges, I can get it in right behind.

Signed-off-by: Jeffrey Martin <Jeffrey_Martin@rapid7.com>
@jmartin-tech
Copy link
Contributor Author

Rebased 👍

@marcparadise marcparadise merged commit 9b13e33 into chef:master Feb 1, 2019
@marcparadise
Copy link
Member

Excellent, thank you again

@jmartin-tech jmartin-tech deleted the delay_validation branch March 30, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants