Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty print version manifest to pkg folder #839

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

balasankarc
Copy link

Description

The version-manifest file that goes into the package is already being pretty printed - /~https://github.com/chef/omnibus/blob/master/lib/omnibus/project.rb#L1100 . Let's do that to the one being stored to pkg folder so it is easier to read.

Maintainers

Please ensure that you check for:

  • [] If this change impacts git cache validity, it bumps the git cache
    serial number
  • [] If this change impacts compatibility with omnibus-software, the
    corresponding change is reviewed and there is a release plan
  • [] If this change impacts compatibility with the omnibus cookbook, the
    corresponding change is reviewed and there is a release plan

@balasankarc balasankarc requested a review from a team as a code owner May 3, 2018 05:46
@tas50
Copy link
Contributor

tas50 commented Jun 13, 2019

@balasankarc Can you rebase this against master, sign off the commit and take a peak at those CI failures.

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
@balasankarc balasankarc force-pushed the pretty-print-version-manifest branch 2 times, most recently from 2952ea2 to 868a8ff Compare June 14, 2019 07:31
@balasankarc
Copy link
Author

@tas50 Rebased. :)

@tas50 tas50 merged commit d5ea615 into chef:master Aug 15, 2019
@tas50
Copy link
Contributor

tas50 commented Aug 15, 2019

Thanks @balasankarc

@balasankarc balasankarc deleted the pretty-print-version-manifest branch August 16, 2019 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants