Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple plugin to get the local timezone. #829

Merged
merged 3 commits into from
Jun 17, 2016
Merged

Conversation

johnbellone
Copy link
Contributor

We have an internal plugin where we are doing the same thing, and we were a little surprised that this didn't exist yet. I didn't think there was a better namespace place to shove this under.

@thommay
Copy link
Contributor

thommay commented Jun 14, 2016

@smurawski can you take a look at the powershell failures in appveyor please?

@mcquin
Copy link
Contributor

mcquin commented Jun 16, 2016

@johnbellone Great addition! Since we don't have a lot of other plugins collecting time information, I don't feel like trying to nest this under a Time plugin makes sense (it was my initial thought, but we don't have a good enough understanding of what the data we want to collect will look like). If we do decide to scope this under another plugin, we can add it as a dependency.

👍 ⌚

@johnbellone
Copy link
Contributor Author

@mcquin Sounds good to me.

@tas50
Copy link
Contributor

tas50 commented Jun 17, 2016

👍

@tas50 tas50 merged commit d1e2fe9 into chef:master Jun 17, 2016
@lamont-granquist
Copy link
Contributor

so this probably breaks half the timezone cookbooks out there in the rest of the world.

node.automatic["timezone"] will override node.default["timezone"] in any cookbook. lots of those use a sub-hash to configure things so it'll obliterate the "schema"

/~https://github.com/L2G/timezone-ii/blob/master/attributes/default.rb#L7-L15

in my own cookbooks I use node.default["timezone"]["value"] and now my runs crash with:

  NoMethodError
  -------------
  undefined method `value' for "PDT":String

@lamont-granquist
Copy link
Contributor

yeah i think unfortunately, i'm going to whack revert on this, i don't think we want this going out in the next chef release without more discussion

@johnbellone
Copy link
Contributor Author

No worries, makes sense to me. Do you want to leave it open?

@tas50
Copy link
Contributor

tas50 commented Jul 1, 2016

@johnbellone We moved everything under node['time'] and shipped 8.17.1. It's all good now

@thommay thommay added Type: Enhancement Adds new functionality. and removed Enhancement labels Jan 24, 2017
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Enhancement Adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants