-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple plugin to get the local timezone. #829
Conversation
@smurawski can you take a look at the powershell failures in appveyor please? |
@johnbellone Great addition! Since we don't have a lot of other plugins collecting time information, I don't feel like trying to nest this under a 👍 ⌚ |
@mcquin Sounds good to me. |
👍 |
so this probably breaks half the timezone cookbooks out there in the rest of the world.
/~https://github.com/L2G/timezone-ii/blob/master/attributes/default.rb#L7-L15 in my own cookbooks I use
|
yeah i think unfortunately, i'm going to whack revert on this, i don't think we want this going out in the next chef release without more discussion |
No worries, makes sense to me. Do you want to leave it open? |
@johnbellone We moved everything under node['time'] and shipped 8.17.1. It's all good now |
We have an internal plugin where we are doing the same thing, and we were a little surprised that this didn't exist yet. I didn't think there was a better namespace place to shove this under.