Improve KVM host and guest detection #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will detect hvm KVM guests
virtualization[:mechanism] would have been great, but we didn't setup the data structure right for this to work hypervisor flag is present anywhere the guest has a hypervisor. It's not just a Xen thing If we find KVM CPUs we're on an old paravirt box and BTMs request for info from 2009 is probably not going to get answered. Sorry BTM
|
This resolves #749 |
|
you really are turning into the cloud whisperer. 👍 |
This has been confirmed using an Openstack guest and host
|
@chef/client-core this is ready for review |
Merged
|
👍 |
tas50
added a commit
that referenced
this pull request
Mar 9, 2016
Improve KVM host and guest detection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we detected KVM hosts via kvm modules, which are actually loaded for both guests and hosts. Instead use /sys/devices/virtual/misc/kvm to determine if the system is KVM in anyway. From there look for a hypervisor cpu feature flag to determine if we're a guest. If that isn't there we're on a host.