Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature checking support to go-criu #60

Merged

Conversation

adrianreber
Copy link
Member

This adds the feature checking interface with the same semantics as the feature checking through libcriu.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2021

Codecov Report

Merging #60 (5b3b8ad) into master (bbf788d) will increase coverage by 1.33%.
The diff coverage is 44.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   25.69%   27.03%   +1.33%     
==========================================
  Files          10       11       +1     
  Lines        1942     2042     +100     
==========================================
+ Hits          499      552      +53     
- Misses       1356     1394      +38     
- Partials       87       96       +9     
Impacted Files Coverage Δ
test/main.go 41.72% <35.71%> (-3.55%) ⬇️
features.go 57.14% <57.14%> (ø)
main.go 60.69% <77.77%> (+3.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf788d...5b3b8ad. Read the comment docs.

This adds the feature checking interface with the same semantics as the
feature checking through libcriu.

Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber adrianreber force-pushed the 2021-12-16-feature-check branch from 046a730 to 5b3b8ad Compare December 16, 2021 19:05
Signed-off-by: Adrian Reber <areber@redhat.com>
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rst0git rst0git merged commit e305910 into checkpoint-restore:master Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants