Fix documentation after setting plugin as module #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kurkle @LeeLenaleee let me know what you think. Not sure why this update should solve the issue but weirdly the vue app JS is not built correctly if we omit the names of the imports. |
|
@kurkle @LeeLenaleee I didn't relate the PR to the issue because I would like to see how it works on GHP before to close the issue. |
LeeLenaleee
approved these changes
May 11, 2023
kurkle
approved these changes
May 11, 2023
|
@kurkle @LeeLenaleee I can confirm you that the development version on doc (master) is now rendering the charts.... The problem is that version 3.0.0 is broken :( |
This was referenced May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr should fix the issue related to the documentation where the chart instances are not available because the chart.js elements are not registered.
The issue sounds to be related to
vuepress-theme-chartjsand how imports are managed.Not clear to me why (apologize) but adding the import names where missing, the app built by webpack/vue seems to have the registration and is importing everything as it should.