Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to version 2.0.0 #777

Merged
merged 8 commits into from
Jul 26, 2022
Merged

Bump to version 2.0.0 #777

merged 8 commits into from
Jul 26, 2022

Conversation

stockiNail
Copy link
Collaborator

No description provided.

@stockiNail stockiNail added this to the 2.0.0 milestone Jul 25, 2022
@stockiNail stockiNail requested review from kurkle and LeeLenaleee July 25, 2022 10:49
LeeLenaleee
LeeLenaleee previously approved these changes Jul 25, 2022
@stockiNail
Copy link
Collaborator Author

stockiNail commented Jul 25, 2022

I have seen a warning from Vue-Press:

[@vue/compiler-sfc] ::v-deep usage as a combinator has been deprecated. Use :deep(<inner-selector>) instead.

The warnings sound to be related to @simonbrunel/vuepress-plugin-versions (file /src/components/VersionsDropdown.vue) and vuepress-theme-chartjs(file /components/Tooltip.vue)

Edit:
Opened 2 issues:

@stockiNail
Copy link
Collaborator Author

I have seen a warning from Vue-Press:

[@vue/compiler-sfc] ::v-deep usage as a combinator has been deprecated. Use :deep(<inner-selector>) instead.

Shall we wait for fix in the other projects?

@LeeLenaleee
Copy link
Collaborator

What if you just upp the version number and not the versions of the used packages

@stockiNail
Copy link
Collaborator Author

What if you just upp the version number and not the versions of the used packages

It works. I rollback the the package-lock.json.

@stockiNail stockiNail merged commit 676c456 into chartjs:master Jul 26, 2022
@stockiNail
Copy link
Collaborator Author

I don't see any npm deployment and also the version is still in draft... Is it usual?

@kurkle
Copy link
Member

kurkle commented Jul 26, 2022

Yes, you need to publish that release, which will trigger the npm publish.

@stockiNail
Copy link
Collaborator Author

oh... I was convinced that last time it was done automatically. I put it in my notes.

Thank you @kurkle

@LeeLenaleee
Copy link
Collaborator

@stockiNail you are not the only one, if you wanna know how to publish (took me some googling) go to the draft click the pencil on the top right to edit it then at the bottom you have a big green publish button

@stockiNail stockiNail deleted the bump2.0.0 branch July 26, 2022 14:32
@stockiNail
Copy link
Collaborator Author

@stockiNail you are not the only one, if you wanna know how to publish (took me some googling) go to the draft click the pencil on the top right to edit it then at the bottom you have a big green publish button

Thank you @LeeLenaleee !!! I know how to do it manually, having other projects where I'm doing that but I was convinced (dont ask me why) here it was all automated, triggered by Bump PR. And I was wondering how the deployment could start based on event of a merged specific PR.... Now it's clear! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants