Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render list inside a viewport #228

Merged
merged 7 commits into from
Apr 2, 2024
Merged

feat: render list inside a viewport #228

merged 7 commits into from
Apr 2, 2024

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Mar 1, 2024

allowing scrolling et al.

almost thinking we could use the list model, add a keybind to copy the id, etc...

wdyt?

allowing scrolling et al.
@caarlos0 caarlos0 requested a review from toby as a code owner March 1, 2024 20:13
@caarlos0 caarlos0 self-assigned this Mar 1, 2024
@caarlos0 caarlos0 requested review from meowgorithm and removed request for toby March 1, 2024 20:13
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@bashbunni
Copy link
Member

I could see it being quite helpful being able to fuzzy find a conversation, then copy the ID. 💭

@cloudbridgeuy
Copy link
Contributor

It would be nice to have this embedded. I use it all the time thought fzf like this:

mods --list --raw 2>&1 | fzf -m --preview 'mods -s $(echo -n {} | awk "{print $1}")' --preview-window=right:60% --height 100% --border

@caarlos0
Copy link
Member Author

caarlos0 commented Apr 2, 2024

@bashbunni good idea, done

@bashbunni
Copy link
Member

added notification msg to show user that the ID was copied to clipboard (yoinked from freeze)
image

@caarlos0 caarlos0 merged commit 917260a into main Apr 2, 2024
12 checks passed
@caarlos0 caarlos0 deleted the list-improvements branch April 2, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants