Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--quiet still dumps ANSI terminal escapes #86

Closed
rwxrob opened this issue Jul 17, 2023 · 3 comments · Fixed by #199
Closed

--quiet still dumps ANSI terminal escapes #86

rwxrob opened this issue Jul 17, 2023 · 3 comments · Fixed by #199

Comments

@rwxrob
Copy link

rwxrob commented Jul 17, 2023

They may be invisible, but they are still a problem when using the filter command from within a Vim session, for example.

$ mods --quiet 'do you like kittens'
^[[?25l ^[[0D^[[2K^[[?25h^[[?1002l^[[?1003lAs an AI, I do not have personal preferences or          emotions, so I do not have the ability to like or dislike anything, including kittens.
@rwxrob rwxrob changed the title --quiet still dumps ASNI terminal escapes --quiet still dumps ANSI terminal escapes Jul 17, 2023
@johnd0e
Copy link

johnd0e commented Aug 8, 2023

Related issue: with redirected output there should not be ANSI escapes either.

@johnd0e johnd0e mentioned this issue Aug 8, 2023
Closed
@caarlos0
Copy link
Member

hey, thanks for reporting this!

it seems like an issue somewhere else in our stack, opened an issue to investigate

charmbracelet/bubbletea#797

@caarlos0
Copy link
Member

a small clarification though: --quiet only stops the generating indicator

This is still a bug nevertheless :)

caarlos0 added a commit that referenced this issue Jan 24, 2024
@caarlos0
fix: do not use a renderer if output is not a tty
446766f 
the renderer will send sequences to clear screen, hide/show mouse, etc,
which will not work if output is not a tty.

fixes #198
fixes #86

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 mentioned this issue Jan 24, 2024
Merged
caarlos0 added a commit that referenced this issue Jan 24, 2024
@caarlos0
fix: do not use a renderer if output is not a tty (#199)
8d6920f 
the renderer will send sequences to clear screen, hide/show mouse, etc,
which will not work if output is not a tty.

fixes #198
fixes #86

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not use a renderer if output is not a tty charmbracelet/mods
3 participants
@caarlos0 @johnd0e @rwxrob