[perceval] Update license and copyright information #623
Conversation
|
Hi @valeriocos Ok, I will look at why the tests are failing. Meanwhile, I need some review of this draft PR. There are a few complications. 😅 |
|
There are some unexpected conditions with a few files where it deletes some part of code too. I had to undo the changes and fix it. I added some extra space as of now to see what all files are being affected because of that. I will dig a bit and see what is the problem. |
|
@vchrombie thank you for the PR! perfect, thanks! |
|
Taking this comment into consideration, I am reverting a few deleted author names and update the PR. |
vchrombie
force-pushed
the
test-copyright-script
branch
2 times, most recently
from
a1231db to
ab59b01
Compare
|
Please @vchrombie ping me when the PR is ready for review. Consider to add some extra info to the commit description (saying that the script updated also the list of authors), thanks! :) |
Sure @valeriocos. 🙂 |
|
you're welcome! |
vchrombie
force-pushed
the
test-copyright-script
branch
2 times, most recently
from
6bd1ecf to
bf4239c
Compare
|
Hi @valeriocos I think I am done. Can you have a look when you are free? |
There was a problem hiding this comment.
LGTM, thanks @vchrombie . Nice job!
Minor comment: you should appear as an author of thes files, since this commit will modify them. However, I understand that:
- if the script is executed by a bot, it wouldn't make sense to list the bot as an author
- the next time the script is executed, you will be listed as an author
In a next iteration, you can try to target also the other files not targeted in this PR
Makes sense.
In how time period you think it would be better to run this script?
Did I miss any files? I have covered all the files in the perceval folder. |
|
sorry @vchrombie I have just realized the the commit message is not properly rendered in the terminal. Everything appears in a single line (see below) Can you check this? Thanks |
|
Sure, let me fix it right now. |
This commit updates license information for every source code file in Perceval. The author names are also updated using a script. Signed-off-by: Venu Vardhan Reddy Tekula <venuvardhanreddytekula8@gmail.com>
vchrombie
force-pushed
the
test-copyright-script
branch
from
bf4239c to
168b577
Compare
It depends on the repo activity. A monthly-based execution could be good, or every 2/4/6 months seems also reasonable. WDYT?
I was referring to the other folders (tests, bin). Maybe the script could be updated to target all files (or specific directories), WDYT? |
Thanks, it looks better now! |
I was thinking on a yearly basis. 😅
Ah, my bad again. I forgot about those files. I was concentrating on just perceval folder. |
|
oops, already merged! No worries, you can submit another PR targeting the remaining folders, thanks! |
This PR updates license information for every source code file in Perceval.
I tried updating this using the tool, vchrombie/grimoirelab-scripts.