-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[schema] Update askbot.csv #812
Conversation
Hi @valeriocos I need to add the I will squash all the commits once I am done with the PR. |
Pull Request Test Coverage Report for Build 2034
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vchrombie, I left just a minor comment. Would be possible to add the description of each field (something similar to /~https://github.com/chaoss/grimoirelab-elk/blob/master/schema/github2_issues.csv)?
Please note that:
- some descriptions can be taken from existing CSVs
- if you think that's too much work we can merge this PR and work on another PR to add the descriptions.
Thanks
Hi @valeriocos
Yes, I will do that. I was waiting for your approval in the procedure. Also, thanks for the suggestion. I will update you on the PR.
Not really, I can push commits to this PR. Once everything is in good shape, I can squash and later we can merge. |
Thanks @vchrombie ! Ping me when the PR is ready! |
d88c056
to
8af3549
Compare
Hi @valeriocos
Please review it when you are free. After the PR is approved, I will squash all these commits into 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @vchrombie . I left a really minor comment.
Please squash the commits in one and ping me when the PR is ready to be merged. Thanks!
This commit updates the fields of the askbot schema and updates the schema to the latest format by adding aggregatable and description columns to the fields. Signed-off-by: Venu Vardhan Reddy Tekula <venuvardhanreddytekula8@gmail.com>
8af3549
to
d5f50a4
Compare
Hi @valeriocos I have squashed the commits too. Please let me know if there are any more changes to do. 🙂 |
Thank you @vchrombie ! |
This PR updates the askbot schema to the latest format.
Reference to #803