TTD: explicit support for enable/disable auto-trace #5202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #else | ||
| JsrtContext *currentContext = JsrtContext::GetCurrent(); | ||
| JsErrorCode cCheck = CheckContext(currentContext, JSRT_MAYBE_TRUE); | ||
| TTDAssert(cCheck == JsNoError, "Must have valid context when setting auto trace status."); |
There was a problem hiding this comment.
Is TTDAssert a release assert? If not, probably should return the error here?
There was a problem hiding this comment.
Looks like it's currently a fatal error in release. It seems like we should just return the error rather than killing the process and let the calls abort if something's wrong.
digitalinfinity
approved these changes
May 20, 2018
mike-kaufman
approved these changes
May 21, 2018
kfarnung
approved these changes
May 21, 2018
chakrabot
pushed a commit
that referenced
this pull request
May 22, 2018
…o-trace Merge pull request #5202 from mrkmarron:rrfix Fix for auto-trace behavior.
chakrabot
pushed a commit
that referenced
this pull request
May 22, 2018
…e/disable auto-trace Merge pull request #5202 from mrkmarron:rrfix Fix for auto-trace behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for auto-trace behavior.