Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix outputs/postgresql docs in Bots.md and README.md #711

Closed
bernhardreiter opened this issue Sep 26, 2016 · 8 comments
Closed

fix outputs/postgresql docs in Bots.md and README.md #711

bernhardreiter opened this issue Sep 26, 2016 · 8 comments

Comments

@bernhardreiter
Copy link
Contributor

Split out from #355 only for the output/postgresql bot.
I've started working on it.

@bernhardreiter
Copy link
Contributor Author

bernhardreiter commented Sep 26, 2016

@SYNchroACK was there a special reason for recommending at last Postgresql 9.4?

E.g. Ubuntu 14.04 LTS still has postgresql 9.3 and probably other stable server GNU distributions as well. So if there is no feature that we are using, which mandates a minimum version to be required, I'd like to remove the recommendation entirely.

@aaronkaplan
Copy link
Member

On 26 Sep 2016, at 12:43, Bernhard E. Reiter notifications@github.com wrote:

@SYNchroACK was there a special reason for recommending at last Postgresql 9.4?

E.g. Ubuntu 14.04 LTS still has postgresql 9.3 and probably other stable server GNU distributions as well. So if there is no feature that we are using, which mandates a minimum required, I'd like to remove the recommendation entirely.

There were some timestamp issues. @sebix knows them.

@bernhardreiter
Copy link
Contributor Author

bernhardreiter commented Sep 26, 2016

My first improvements are in branch /~https://github.com/Intevation/intelmq/tree/dev-postgresql-docs-patch-04, e.g. see the diff.

@bernhard-herzog
Copy link
Contributor

was there a special reason for recommending at last Postgresql 9.4?

I guess that's for the postgresql-output bot. Another bot that uses PostgreSQL is certbund_contact which could profit from using PostgreSQL >= 9.4 because it supports GiST indexes for the cidr type which would make it easier to efficiently query for e.g. all networks containing a given IP-address. It's possible to work around it, though, so 9.4 is not really required.

@sebix
Copy link
Member

sebix commented Sep 26, 2016

There were some timestamp issues. @sebix knows them.

No, 9.4 is not necessary for the output bot. The output formatting parameter timezone OF is only available in >= 9.4, that's all.
See: https://www.postgresql.org/docs/9.4/static/functions-formatting.html

@bernhardreiter
Copy link
Contributor Author

@sebix what is the time-zone offset formatting used for? (Personally I believe that if a time-zone is needed, it should be the full tz name, because otherwise you cannot calculate time-zone related things like daylight saving time).

Would it be okay to write something like:
If you use v <=9.4 that gives you the possibility to use the time-zone output formatting for date-times and the GiST index for the cidr type.

@sebix
Copy link
Member

sebix commented Sep 27, 2016

On 09/27/2016 08:27 AM, Bernhard E. Reiter wrote:

@sebix /~https://github.com/sebix what is the time-zone offset
formatting used for?

We used it in out intelmqcli, but that's not at all related to the
output bot. But that's what @aaronkaplan meant.

I do not know why the limitation for the output bot exists, maybe it
hasn't been tested for <9.4?

The limitation has been added in
ad87111 by @SYNchroACK

@bernhardreiter
Copy link
Contributor Author

Yes, I saw that @SYNchroACK added the recommendation, this is why I had asked him in my second commend above. :-)

We run the output bot in some testing environments with Ubuntus 14.04 LTS Postgresql 9.3,
and have not noticed a big problem so far.

bernhardreiter added a commit to Intevation/intelmq that referenced this issue Sep 27, 2016
Unifies the installation instructions in the directory of the bot.
* links the README.md from docs/Bots.md
* added explanation for the two ways to set up a) local b) network
* createuser: moving to non-interative and --no-createrole for
  a higher priviledge separation,as createdb can always be done
  by the database-superuser.
* postgresql version: recommending v>=9.4 linking the rationale,
  allowing any supported version

resolves certtools#711
@sebix sebix closed this as completed in #712 Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants