Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatNXmx: open files in SWMR mode #478

Merged
merged 3 commits into from
Feb 8, 2022
Merged

FormatNXmx: open files in SWMR mode #478

merged 3 commits into from
Feb 8, 2022

Conversation

rjgildea
Copy link
Contributor

@rjgildea rjgildea commented Feb 8, 2022

No description provided.

Copy link

@benjaminhwilliams benjaminhwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As discussed, any tests for this would be rather involved since we would need to simulate the creation of files in SWMR mode, while also trying to read them. So that might be one for the long list.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #478 (236c930) into main (42b1945) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   65.70%   65.70%           
=======================================
  Files         185      185           
  Lines       17045    17045           
  Branches     2397     2397           
=======================================
  Hits        11200    11200           
  Misses       5281     5281           
  Partials      564      564           

@graeme-winter
Copy link
Collaborator

I may be able to come up with a test, but that should not hold up this PR

I did this for the original PIA SWMR stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants