Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible memory reference cycle #49

Closed
gunt3001 opened this issue Mar 25, 2014 · 1 comment
Closed

Possible memory reference cycle #49

gunt3001 opened this issue Mar 25, 2014 · 1 comment

Comments

@gunt3001
Copy link

Hi!

I ran into a memory leak in my project earlier and I tracked it down to -setupLabel. I found out that issue #23 is still there because the line

if ([notification.userInfo objectForKey:@"delegate"] == self.window) {

still refers to self instead of weakSelf

I'm pretty new with Objective-C, so I apologize if I'm mistaken.
Anyway, thanks for the great work.

@cbpowell
Copy link
Owner

Good catch, thanks! Incorporated this fix into v1.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants