Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to fastutil 8.5.8 and fix FeatureVector bug in #840 #1975

Merged
merged 12 commits into from
Sep 18, 2022

Conversation

lintool
Copy link
Member

@lintool lintool commented Sep 18, 2022

Details of the bug are described in #840.

We've known about this issue for a long time, but since it has a massive impact (lots of small score changes for PRF experiments), I delayed patching until a major change. Since Lucene 8 -> 9 upgrade has already caused lots of disruption, this is a good time to fix this issue.

An additional reason: we're moving from RM3 to Rocchio as the "default" PRF technique. Good to fix before Rocchio numbers get "entrenched".

@codecov-commenter
Copy link

Codecov Report

Base: 58.30% // Head: 58.47% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (630c20b) compared to base (3dfce53).
Patch coverage: 85.93% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1975      +/-   ##
============================================
+ Coverage     58.30%   58.47%   +0.17%     
- Complexity     1067     1084      +17     
============================================
  Files           186      186              
  Lines         10147    10161      +14     
  Branches       1398     1404       +6     
============================================
+ Hits           5916     5942      +26     
+ Misses         3758     3746      -12     
  Partials        473      473              
Impacted Files Coverage Δ
...va/io/anserini/index/generator/TweetGenerator.java 55.78% <0.00%> (ø)
.../main/java/io/anserini/rerank/lib/Rm3Reranker.java 52.94% <25.00%> (ø)
...n/java/io/anserini/rerank/lib/RocchioReranker.java 57.79% <50.00%> (ø)
src/main/java/io/anserini/util/FeatureVector.java 97.05% <96.22%> (+14.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lintool lintool merged commit a60e842 into master Sep 18, 2022
@lintool lintool deleted the fastutil-8.5.8-upgrade branch September 22, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants