-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to fastutil 8.5.8 and fix FeatureVector bug in #840 #1975
Conversation
Codecov ReportBase: 58.30% // Head: 58.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1975 +/- ##
============================================
+ Coverage 58.30% 58.47% +0.17%
- Complexity 1067 1084 +17
============================================
Files 186 186
Lines 10147 10161 +14
Branches 1398 1404 +6
============================================
+ Hits 5916 5942 +26
+ Misses 3758 3746 -12
Partials 473 473
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Details of the bug are described in #840.
We've known about this issue for a long time, but since it has a massive impact (lots of small score changes for PRF experiments), I delayed patching until a major change. Since Lucene 8 -> 9 upgrade has already caused lots of disruption, this is a good time to fix this issue.
An additional reason: we're moving from RM3 to Rocchio as the "default" PRF technique. Good to fix before Rocchio numbers get "entrenched".