-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement unexporting variables #2098
Conversation
ac8531a
to
e3137c8
Compare
Just took a look at this, mostly looks good. I think we should call this There are a few tests we should have:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing an actual review so it shows up as requested changes in my PR lists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dope, LGTM!
Did some very minor stuff. For example, you can do ${VAR:-unset}
, to allow figuring out if a variable is unset without triggering an error, which is useful for tests.
#1263