-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all values lists of strings, instead of strings #2458
Comments
I personally prefer the terminology list, but it doesn't really matter.
Associative arrays are useful, but they can be emulated with a list of 2-lists representing keys and values. On the other hand, I don't think that treating a list as an implicit associative array with natural number keys, Javascript-style, is necessarily a problem. If there's any mechanism for indexing into a list with a natural number, then that has the possibility of failing even if there's no notion of an associative array. |
hmmm... I still think clear separation between list and string is the way to go. Essentially introducing an additional type: list, which maintain the static-typing of Just. I think it's more intuitive than ditching singular strings. |
Adding two types, lists and strings, would mean that just would either become dynamically typed, and have type errors when you tried to use a list where a string was necessary, or vice versa; or we would have to add a static type system, which would be a huge undertaking. |
In a way, though, you still be creating two types since a list is a composite type; it needs elements to make sense (or not). As for dynamic typing, like I mention below, singular strings will convert to singular lists. This conversion can happen somewhere between parsing and evaluation. Besides, isn't Just an interpreter of commands, dynamic typing shouldn't come as a shock to it. Re-reading Drew response to another hacker's experiment on whitespaces in shell here, he mentions that the key ingredient is adding list of strings (alongside strings). I think for Just, we should treat strings like a list with one element. Citing your example: PS: I haven't looked at Just source in a long while, maybe out of touch with this reality. Lemme know |
I've been taking a shot at implementing the infrastructure for this idea (in the context of #1988), and changing the data model seems to be quite doable. However, I've been hitting a dead end regarding the exact semantics. The problem is that this issue makes a key assumption that "All current values, instead of being strings, would be lists containing single strings." However, this is incompatible with the idea in #1988 to use such lists for lossless handling of variadic recipe arguments, which is effectively already a kind of list in the current Just implementation. Consider this example recipe: set unstable # for the && || control flow ops
set positional-arguments
@example *args:
echo bool={{ args && "true" || "false" }}
echo path={{ args / "foo" }}
echo narg=$# The current behavior can be demonstrated as follows, as the $ just example
bool=false
path=/foo
narg=0
$ just example ''
bool=false
path=/foo
narg=1
$ just example a b
bool=true
path=a b/foo
narg=2
$ just example 'a b'
bool=true
path=a b/foo
narg=1 If the I think this means that once we have list values, we have a choice:
(The third choice would be to introduce a breaking change, but I wouldn't want that.) I'm biased because I really want #1988 lossless recipe arg forwarding, and I'm not sure if it's ever possible to get that if we don't use lists for that feature. But that will mean that all existing operators will have to treat multi-item lists and single-strings equivalently as per their joined string representation. For example Next steps:
|
Good summary! I agree with all your points. Some thoughts:
Anyways, will definitely hold off on stabilizing |
In support of: * casey#2458 * casey#1988 A `Val` is a list of strings, but at each point of usage we must decide whether to view it as a singular joined string or as a list of its parts. Previously, Just values were single strings, so in most places we have to invoke `to_joined()` in order to maintain compatibility. In particular, recipes, functions, and operators like `+` or `/` operate solely on strings. This includes logical operators like `&&`, which continue to be defined on strings. That means, the values `[]` and `['']` are currently completely equivalent. So far, this is a purely internal change without externally visible effects. Only the `Bindings`/`Scope`/`Evaluator` had API changes. No new syntax is implemented. However, in expectation of expressions that build lists, a new `evaluate_list_expression() -> Vec<String>` method is introduced that could be used to implement splat or generator expressions. It is already referenced wherever we have lists of arguments, e.g. variadic functions like `shell()` and dependency arguments. But because singular expressions are equivalent to a joined string, this is an unobservable detail for now. For experimenting with lists of strings, variadic recipe parameters like `*args` now produce a multi-part Val, and default to an empty list (not a list with an empty string). Because all operators use `to_joined()`, this is an unobservable implementation detail. However, if any operator becomes list-aware, then this detail should be reverted, or moved behind an unstable setting. For better understanding of the current behavior, I added a bunch of tests. These will help detect regressions if functions or operators become list-aware. No existing tests had to be touched. Next steps: This change is just the foundation for other work, but some ideas are mutually exclusive. Relevant aspects: * list syntax in casey#2458 * list aware operators in casey#2458 * lossless forwarding of variadics: casey#1988 * invoking dependencies multiple times: casey#558 The preparatory work like `evaluate_list_expression()` is biased towards implementing a splat operator that would enable casey#2458 list syntax and casey#1988 list forwarding, but doesn't commit us to any particular design yet.
Just values are all strings. This is convenient, because it means that Just is effectively statically typed. It is impossible to provoke a type error.
However, it means that many desirable things are impossible:
*arg
. Currentlyarg
is a space-separated string, but users may want to do something with each entry in the list, and re-splitting is error-prone.true/false
, but these are also valid strings.We could add a type system, see #528. But another interesting option would be to change our single type from strings to lists of strings. This is done in rc, Plan 9s shell.
This seems crazy! Everything is a list? However, consider this: The shell, and Just, benefit from enormous simplicity because everything is a string. No type errors! No type system! We could abandon this, and add a type system, but another path is to make the one type we do have more powerful.
All current values, instead of being strings, would be lists containing single strings. When used in interpolations, or as arguments to
/
and+
, an list of a single string would behave in exactly the same way as a string does now, so this would be a backwards compatible change.This would allow the following nice things:
false
value would be the empty list, and any non-empty list is true.['']
is true, so it would be possible to provide the empty string as a value, and still allow a fallback withvalue || fallback
.make
has a ton of functions which treat a string as a space-separated list. These are useful, but error prone, so I haven't wanted to add these. We could add useful, non-error-prone versions of these.+
could append an extension to every element of a list:["hello", "goodbye"] + '.c'
->["hello.c", "goodbye".c]
/
:["/", "/usr"] / "bin"
->["/bin", "/usr/bin"]
false
could be represented by the empty list, and all other values would be interpreted as true. This['']
would be true, allowing the user to provide the empty string for a value.for
which evaluates to a list:for a in var { a + ".c" }
The main downside, I think, is that it is very unfamiliar and counter-intuitive. Users are used to shell-like languages, including
make
andjust
, where everything is a string. Everything is a list of strings is very weird.rc
implements and makes a compelling case for lists of lists being the single type, but it's unfamiliar and mostly forgotten.Open questions:
The text was updated successfully, but these errors were encountered: