Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #409 #432

Merged
merged 2 commits into from
May 28, 2023
Merged

Conversation

jbogaardt
Copy link
Collaborator

No description provided.

@jbogaardt jbogaardt linked an issue May 28, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: -0.04 ⚠️

Comparison is base (25279a1) 81.79% compared to head (62d66f0) 81.76%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   81.79%   81.76%   -0.04%     
==========================================
  Files          80       80              
  Lines        4718     4721       +3     
  Branches      804      805       +1     
==========================================
+ Hits         3859     3860       +1     
- Misses        657      658       +1     
- Partials      202      203       +1     
Flag Coverage Δ
unittests 81.76% <71.42%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chainladder/core/tests/test_grain.py 100.00% <ø> (ø)
chainladder/core/triangle.py 88.86% <66.66%> (-0.41%) ⬇️
chainladder/__init__.py 76.47% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jbogaardt jbogaardt merged commit 711d749 into master May 28, 2023
@jbogaardt jbogaardt deleted the 409-bug-changing-grain-with-an-off-cycle-close branch May 29, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] changing grain with an off-cycle close.
2 participants