Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Friedland gl and xyz disposal rate data sets. #353

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

genedan
Copy link
Contributor

@genedan genedan commented Nov 2, 2022

Partially addresses #346.

@jbogaardt
Copy link
Collaborator

Thanks @genedan. Quite a day, 3 PRs from 3 different contributors - it's really exciting to see this community grow.

On this PR in particular,
For the datasets to be packaged with the releases, they have to be registered in MANIFEST.in

I haven't actually tried using load_sample with these new datasets, but I do wonder if it works. Its a horribly written function from my earlier days that has a lot of hardcodes of column names to simply call the Triangle constructor on pre-packaged data. It makes me cringe looking at it, but it may block users from accessing the triangles.

We now have quite a library of sample data, it might even be a good idea to make them discoverable somehow from python itself. Open to ideas on this. sklearn makes each dataset a discoverable function on the datasets module:

from sklearn import datasets
datasets.load_iris() # accessible through tab-complete

Very different to our setup, maybe some sort of list_samples function might solve this without causing too many breaking changes.

@jbogaardt jbogaardt merged commit c0d2fcd into casact:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants