Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analyses notebook #236

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Update analyses notebook #236

merged 2 commits into from
Jun 30, 2022

Conversation

maxrjones
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jun 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
cmip6-downscaling ⬜️ Ignored (Inspect) Jun 27, 2022 at 7:16PM (UTC)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@maxrjones maxrjones requested a review from orianac June 23, 2022 02:28
@orianac
Copy link
Member

orianac commented Jun 23, 2022

@meghanrjones these all look good to me- thanks for the fixes! the only additional things i can think of that might be good to throw in with these fixes is:

  • having the cmap be blue/brown (with blue positive) for precip and a hot/cold cmap for temp
  • adding "percent" to the cmap label when diff_method=='percent' and "[-] to colorba label when diff_method=='absolute'

@maxrjones maxrjones changed the title Fix a few typos Update analyses notebook Jun 27, 2022
@maxrjones maxrjones merged commit 1170236 into main Jun 30, 2022
@maxrjones maxrjones deleted the qaqc-update branch June 30, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants