Make location of .xession-errors depend on user configuration #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to choose the logic for .xsession-errors placement.
|
Hey! madpilot78 has not signed the Canonical CLA which is required to get this contribution merged on this project.
Please head over to https://ubuntu.com/legal/contributors to read more about it. |
vishwin
pushed a commit
to vishwin/freebsd-ports
that referenced
this pull request
Dec 29, 2023
- Add patch to use setusercontext(3) to setup user environment, so it respects login.conf among other things [1] - Use autoreconf, since patch requires regenerating configure script to check for setusercontext(3) [2] - Explicitly disable libaudit support, not supported in FreeBSD [3] - Add QT5 options, disabled by default, to control linking against qt5 [4] - Import patch adding option to enable alternative location for .xsession-errors file [5] - Correctly define runtime dependencies - Forcibly disable installation of apparmor files - Install PAM configuration files as samples, so in the future they are not overwritten if customized - Pet portclippy/portfmt - Regenerate patches Upstreaming: [1] canonical/lightdm#334 [5] canonical/lightdm#335 Many thanks to all people involved! PR: 266532 [1] [2], 273720 [1], 275885 [3] [4] [5] Tested by: Ivan Rozhuk <rozhuk.im@gmail.com>, Daniel Tameling <tamelingdaniel@gmail.com> (provided setusercontext patch), Anton Saietskii <vsasjason@gmail.com>
|
@madpilot78 you can put me in the contact field, thanks! |
This was referenced Dec 19, 2024
|
Is there any update on merging this PR? |
|
Rather than trying to auto-detect, it would be better to make it a string option defaulting to the legacy value. That way users can set it to whatever they want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have extended on the patch in #287 by adding a configuration file variable for lightdm to control how the location of
.xsession-errorsis chosen.I added a
smart-xsession-errors, which is off by default, that allows to switch from the old behavior (putting it in~/.xsession-errors) to the algorith suggested in #287This patch is being considered for inclusion in the freebsd ports tree for lightdm [1]. I decided to add a configuration variable and set it to false (implying old behavior), because I don't feel comfortable forcing a change of the location of this file on users. This due to the fact that the location of this file is historical behavior and expected by the users.
[1] https://bugs.freebsd.org/266532 and https://bugs.freebsd.org/275885