Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: dynamically import sentry lib in error catch clause #19607

Merged
merged 1 commit into from
Feb 27, 2025
Merged

perf: dynamically import sentry lib in error catch clause #19607

merged 1 commit into from
Feb 27, 2025
+1 −1

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Feb 27, 2025 •
edited
Loading

What does this PR do?

  • in apiRouteMiddleware (used as a wrapper for app router APIs), dynamically import Sentry lib in error catch clause

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Already tested
Screenshot 2025-02-27 at 12 24 09 PM

@graphite-app graphite-app bot requested a review from a team February 27, 2025 17:18
@hbjORbj hbjORbj changed the title perf: dynamically import sentry lib perf: dynamically import sentry lib in error catch clause Feb 27, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Feb 27, 2025 5:19pm
calcom-web-canary ⬜️ Ignored (Inspect) Feb 27, 2025 5:19pm

@hbjORbj hbjORbj changed the title perf: dynamically import sentry lib in error catch clause perf: dynamically import sentry lib in error catch handler Feb 27, 2025
@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 27, 2025
@dosubot dosubot bot added the performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive label Feb 27, 2025
@hbjORbj hbjORbj added ready-for-e2e and removed performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive labels Feb 27, 2025
@hbjORbj hbjORbj changed the title perf: dynamically import sentry lib in error catch handler perf: dynamically import sentry lib in error catch clause Feb 27, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 27, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/27/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj enabled auto-merge (squash) February 27, 2025 17:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025 •
edited
Loading

E2E results are ready!

@hbjORbj hbjORbj merged commit 2cf7673 into main Feb 27, 2025
46 of 66 checks passed
@hbjORbj hbjORbj deleted the perf/dynamically-import-sentry-lib branch February 27, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emrysal emrysal emrysal approved these changes

Assignees
No one assigned
Labels
consumer core area: core, team members only ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @emrysal @keithwillcode