Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add flex-wrap to fix overflow #19584

Merged
merged 2 commits into from
Feb 27, 2025
Merged

fix: add flex-wrap to fix overflow #19584

merged 2 commits into from
Feb 27, 2025

Conversation

scarlachs
Copy link
Contributor

@scarlachs scarlachs commented Feb 26, 2025

What does this PR do?

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set? no
  • What are the minimal test data to have? user login
  • What is expected (happy path) to have (input and output)? profile settings, multiple emails on multiple rows
  • Any other important info that could help to test that PR

Checklist

Copy link

vercel bot commented Feb 26, 2025

@scarlachs is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team February 26, 2025 17:58
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 26, 2025
@github-actions github-actions bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Feb 26, 2025
Copy link
Contributor

github-actions bot commented Feb 26, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "add flex-wrap to fix overflow". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link

graphite-app bot commented Feb 26, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/26/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/26/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/27/25)

1 label was added to this PR based on Keith Williams's automation.

@retrogtx retrogtx changed the title add flex-wrap to fix overflow fix: add flex-wrap to fix overflow Feb 27, 2025
Copy link
Contributor

@retrogtx retrogtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for noticing this and making a PR!

@retrogtx retrogtx enabled auto-merge (squash) February 27, 2025 04:30
@retrogtx retrogtx merged commit c1f33e0 into calcom:main Feb 27, 2025
32 of 36 checks passed
Copy link
Contributor

E2E results are ready!

@anikdhabal
Copy link
Contributor

anikdhabal commented Feb 27, 2025

Now:-
Screenshot 2025-02-27 092018
We need 2x per row here. Could pls made a follow-up pr @retrogtx @scarlachs

@scarlachs
Copy link
Contributor Author

@anikdhabal @retrogtx
A
Screenshot 2025-02-27 at 19 15 28

B
Screenshot 2025-02-27 at 19 16 48

which one do you prefer, A or B? 2x mails per row with button or 2x mails per row and button on new row?

@retrogtx
Copy link
Contributor

retrogtx commented Feb 27, 2025

@anikdhabal @retrogtx A Screenshot 2025-02-27 at 19 15 28

B Screenshot 2025-02-27 at 19 16 48

which one do you prefer, A or B? 2x mails per row with button or 2x mails per row and button on new row?

thank you very much for this, but a relevant PR has been merged 🙏

edit: went with B btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Email addresses overflow parent
3 participants